On Apr 1, 2009, at 4:32 PM, Scott Wood wrote:
Becky Bruce wrote:
On Apr 1, 2009, at 4:15 PM, Scott Wood wrote:
Legacy NAND is marked for feature removal after April 2009 (i.e. this upcoming release). There are still several boards that reference it (though many do so only for disk-on-chip support which has been silently disabled for a while now). These boards will now fail to build with
Drum roll....? You're missing the rest of your sentence, or you have too much sentence, or something.
D'oh. The next line started with "#error", so git treated it as a comment.
Commit amended to say "These boards will now fail to build with #error, though the code is still there if the user removes #error."
Thanks ;)
+#error This code is broken and will be removed outright in the next release. +#error If you need diskonchip support, please update +#error drivers/mtd/nand/diskonchip.c to work with u-boot.
"to work with u-boot"? As opposed to what, exactly?
Linux, where the code was taken from as part of the NAND subsystem importation.
How about "please update blah to be functional"
"be functional" == "work". I was just clarifying the nature of the fixing that needed to be done.
it wasn't the "work" I had a problem with, it was the "with u-boot" part, and getting rid of the "with u-boot" made "work" sound silly :)
But if you're actually talking about u-boot vs linux, the comment is fine as is.
Thanks, B