Hi there,
On Sep 6, 2013, at 6:23 PM, Przemyslaw Marczak wrote:
Hello Pantelis,
On 09/06/2013 03:24 PM, Pantelis Antoniou wrote: Hi there,
Can we have a config option for these two values instead of magic numbers?
With the defaults being set at 10 & 200 ms.
Regards
-- Pantelis
I'm not sure that this option is needed. Some cards I/O errors can be avoided by increasing timeout and has no negative influence on other cards read/write operations performance. Moreover there are a lot of timeout values defined in sdhci and mmc drivers, so why should I put at config just only one? Maybe the simplest solution is to leave at this code only 200 ms value. What do you think?
Still, it's a magic constant in the code; you don't have to export it to boards, just put it in the same source file just before it's use.
Protect it with an #ifndef statement in case someone else would like to override it.
Regards
-- Pantelis
Regards,
-- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak@samsung.com