Re: [U-Boot-Users] [PATCH] version_autogenerated.h: use printf rather than echo -n

In message 200805022347.31319.vapier@gentoo.org you wrote:

On Friday 02 May 2008, Mike Frysinger wrote:

...

$(VERSION_FILE):

• @( echo -n "#define U_BOOT_VERSION \"U-Boot " ; \
  

• echo -n "$(U_BOOT_VERSION)" ; \
  

• echo -n $(shell $(CONFIG_SHELL) $(TOPDIR)/tools/setlocalversion \
  

• 	 $(TOPDIR)) ; \
  

• echo "\"" ) > $@.tmp
  

• @( printf '#define U_BOOT_VERSION "U-Boot %s%s"\n' "$(U_BOOT_VERSION)">  \
  

•  $(shell $(CONFIG_SHELL) $(TOPDIR)/tools/setlocalversion $(TOPDIR)) \
  

•  ) > $@.tmp
  

i realized this may break if the setlocalversion generates a space ... but i dont think that's possible ? if it is, then we should quote the $(shell ...)

I added quotes, just to be sure.

Thanks.

Best regards,

Wolfgang Denk