On 27/09/2019 03:48, Simon Glass wrote:
On Tue, 17 Sep 2019 at 09:52, Simon Glass sjg@chromium.org wrote:
Hi Matthias,
On Tue, 17 Sep 2019 at 00:29, Matthias Brugger mbrugger@suse.com wrote:
Hi Simon,
On 17/09/2019 07:48, Simon Glass wrote:
Hi,
On Thu, 5 Sep 2019 at 02:49, matthias.bgg@kernel.org wrote:
From: Matthias Brugger mbrugger@suse.com
According to the device tree specification, the default value for
There seems to be something missing here/...
Argh, you are right, I accidentally deleted one line from the commit message. The correct paragraph should read like this:
<snip> According to the device tree specification, the default value for #size-cells is 1, but fdt_size_cells() was returning 2 if this property was not present. </snip>
BTW this series is a fix and I'd like to see it in v2019.10-rc5. I'm not sure who is to take it, you or Tom.
Regards, Matthias
was not present.
This patch also makes fdt_address_cells() and fdt_size_cells() conform to the behaviour documented in libfdt.h. The defaults are only returned if fdt_getprop() returns -FDT_ERR_NOTFOUND, otherwise the actual error is returned.
This is based on upstream commit: aa7254d ("libfdt: return correct value if #size-cells property is not present") but misses the test case part, as we don't implement them in U-Boot.
Signed-off-by: Matthias Brugger mbrugger@suse.com
This is v2 but I don't see a change log?
I put the changelog into the cover letter: https://patchwork.ozlabs.org/cover/1158304/
From your email I understand that you prefer a patch by patch changelog, correct?
Both is best. If you use patman it does this for you.
Reviewed-by: Simon Glass sjg@chromium.org
Regards, Simon