Re: [PATCH v3 6/7] clk: treewide: switch to clock dump from clk_ops

On 7/14/23 17:24, Igor Prusov wrote:

Switch to using new dump operation in clock provider drivers instead of overriding soc_clk_dump.

Signed-off-by: Igor Prusov ivprusov@sberdevices.ru

arch/mips/mach-pic32/cpu.c | 23 --------------- drivers/clk/aspeed/clk_ast2600.c | 13 ++++----- drivers/clk/clk_k210.c | 11 +++----- drivers/clk/clk_pic32.c | 39 ++++++++++++++++++++++++++ drivers/clk/clk_versal.c | 7 ++++- drivers/clk/clk_zynq.c | 19 ++++--------- drivers/clk/clk_zynqmp.c | 13 ++++----- drivers/clk/imx/clk-imx8.c | 11 +++----- drivers/clk/mvebu/armada-37xx-periph.c | 5 +++- drivers/clk/stm32/clk-stm32mp1.c | 29 ++++++------------- 10 files changed, 83 insertions(+), 87 deletions(-)

diff --git a/arch/mips/mach-pic32/cpu.c b/arch/mips/mach-pic32/cpu.c index ec3c250531..99401745da 100644 --- a/arch/mips/mach-pic32/cpu.c +++ b/arch/mips/mach-pic32/cpu.c @@ -148,26 +148,3 @@ const char *get_core_name(void) return str; } #endif -#ifdef CONFIG_CMD_CLK

-int soc_clk_dump(void) -{

• int i;
• printf("PLL Speed: %lu MHz\n",

•       CLK_MHZ(rate(PLLCLK)));
  

• printf("CPU Speed: %lu MHz\n", CLK_MHZ(rate(PB7CLK)));
• printf("MPLL Speed: %lu MHz\n", CLK_MHZ(rate(MPLL)));
• for (i = PB1CLK; i <= PB7CLK; i++)

• printf("PB%d Clock Speed: %lu MHz\n", i - PB1CLK + 1,
  

•        CLK_MHZ(rate(i)));
  

• for (i = REF1CLK; i <= REF5CLK; i++)

• printf("REFO%d Clock Speed: %lu MHz\n", i - REF1CLK + 1,
  

•        CLK_MHZ(rate(i)));
  

• return 0;

-} -#endif diff --git a/drivers/clk/aspeed/clk_ast2600.c b/drivers/clk/aspeed/clk_ast2600.c index b3cc8392fa..e1365d3f81 100644 --- a/drivers/clk/aspeed/clk_ast2600.c +++ b/drivers/clk/aspeed/clk_ast2600.c @@ -1109,6 +1109,7 @@ struct aspeed_clks { const char *name; };

+#if IS_ENABLED(CONFIG_CMD_CLK) static struct aspeed_clks aspeed_clk_names[] = { { ASPEED_CLK_HPLL, "hpll" }, { ASPEED_CLK_MPLL, "mpll" }, @@ -1123,18 +1124,12 @@ static struct aspeed_clks aspeed_clk_names[] = { { ASPEED_CLK_HUARTX, "huxclk" }, };

-int soc_clk_dump(void) +static int ast2600_clk_dump(struct udevice *dev) {

• struct udevice *dev; struct clk clk; unsigned long rate; int i, ret;

• ret = uclass_get_device_by_driver(UCLASS_CLK, DM_DRIVER_GET(aspeed_scu),

• 			  &dev);
  

• if (ret)

• return ret;
  

• printf("Clk\t\tHz\n");

  for (i = 0; i < ARRAY_SIZE(aspeed_clk_names); i++) {

@@ -1167,11 +1162,15 @@ int soc_clk_dump(void)

return 0; } +#endif

struct clk_ops ast2600_clk_ops = { .get_rate = ast2600_clk_get_rate, .set_rate = ast2600_clk_set_rate, .enable = ast2600_clk_enable, +#if IS_ENABLED(CONFIG_CMD_CLK)

• .dump = ast2600_clk_dump,

+#endif };

static int ast2600_clk_probe(struct udevice *dev) diff --git a/drivers/clk/clk_k210.c b/drivers/clk/clk_k210.c index 2f17152021..058940b828 100644 --- a/drivers/clk/clk_k210.c +++ b/drivers/clk/clk_k210.c @@ -1276,16 +1276,10 @@ static void show_clks(struct k210_clk_priv *priv, int id, int depth) } }

-int soc_clk_dump(void) +static int k210_clk_dump(struct udevice *dev) {

• int ret;

• struct udevice *dev; struct k210_clk_priv *priv;

• ret = uclass_get_device_by_driver(UCLASS_CLK, DM_DRIVER_GET(k210_clk),

• 			  &dev);
  

• if (ret)

• return ret;
  

  priv = dev_get_priv(dev);

  puts(" Rate Enabled Name\n");

@@ -1304,6 +1298,9 @@ static const struct clk_ops k210_clk_ops = { .set_parent = k210_clk_set_parent, .enable = k210_clk_enable, .disable = k210_clk_disable, +#if IS_ENABLED(CONFIG_CMD_CLK)

• .dump = k210_clk_dump,

+#endif };

static int k210_clk_probe(struct udevice *dev) diff --git a/drivers/clk/clk_pic32.c b/drivers/clk/clk_pic32.c index ef06a7fb9f..f756fc88f0 100644 --- a/drivers/clk/clk_pic32.c +++ b/drivers/clk/clk_pic32.c @@ -20,6 +20,8 @@

DECLARE_GLOBAL_DATA_PTR;

+#define CLK_MHZ(x) ((x) / 1000000)

/* Primary oscillator */ #define SYS_POSC_CLK_HZ 24000000

@@ -385,9 +387,46 @@ static ulong pic32_set_rate(struct clk *clk, ulong rate) return rate; }

+#if IS_ENABLED(CONFIG_CMD_CLK) +static int pic32_dump(struct udevice *dev) +{

• int i;
• struct clk clk;
• clk.dev = dev;
• clk.id = PLLCLK;
• printf("PLL Speed: %lu MHz\n",

•       CLK_MHZ(pic32_get_rate(&clk)));
  

• clk.id = PB7CLK;
• printf("CPU Speed: %lu MHz\n", CLK_MHZ(pic32_get_rate(&clk)));
• clk.id = MPLL;
• printf("MPLL Speed: %lu MHz\n", CLK_MHZ(pic32_get_rate(&clk)));
• for (i = PB1CLK; i <= PB7CLK; i++) {

• clk.id = i;
  

• printf("PB%d Clock Speed: %lu MHz\n", i - PB1CLK + 1,
  

•        CLK_MHZ(pic32_get_rate(&clk)));
  

• }
• for (i = REF1CLK; i <= REF5CLK; i++) {

• clk.id = i;
  

• printf("REFO%d Clock Speed: %lu MHz\n", i - REF1CLK + 1,
  

•        CLK_MHZ(pic32_get_rate(&clk)));
  

• }
• return 0;

+} +#endif

static struct clk_ops pic32_pic32_clk_ops = { .set_rate = pic32_set_rate, .get_rate = pic32_get_rate, +#if IS_ENABLED(CONFIG_CMD_CLK)

• .dump = pic32_dump,

+#endif };

static int pic32_clk_probe(struct udevice *dev) diff --git a/drivers/clk/clk_versal.c b/drivers/clk/clk_versal.c index faebbab1c6..1b739a9c8d 100644 --- a/drivers/clk/clk_versal.c +++ b/drivers/clk/clk_versal.c @@ -523,7 +523,8 @@ static int versal_clock_get_rate(u32 clk_id, u64 *clk_rate) return 0; }

-int soc_clk_dump(void) +#if IS_ENABLED(CONFIG_CMD_CLK) +static int versal_clk_dump(struct udevice __always_unused *dev) { u64 clk_rate = 0; u32 type, ret, i = 0; @@ -546,6 +547,7 @@ int soc_clk_dump(void)

return 0; } +#endif

static void versal_get_clock_info(void) { @@ -737,6 +739,9 @@ static struct clk_ops versal_clk_ops = { .set_rate = versal_clk_set_rate, .get_rate = versal_clk_get_rate, .enable = versal_clk_enable, +#if IS_ENABLED(CONFIG_CMD_CLK)

• .dump = versal_clk_dump,

+#endif };

static const struct udevice_id versal_clk_ids[] = { diff --git a/drivers/clk/clk_zynq.c b/drivers/clk/clk_zynq.c index be5226175f..d492eea3b0 100644 --- a/drivers/clk/clk_zynq.c +++ b/drivers/clk/clk_zynq.c @@ -454,6 +454,7 @@ static int dummy_enable(struct clk *clk) return 0; }

+#if IS_ENABLED(CONFIG_CMD_CLK) static const char * const clk_names[clk_max] = { "armpll", "ddrpll", "iopll", "cpu_6or4x", "cpu_3or2x", "cpu_2x", "cpu_1x", @@ -468,22 +469,10 @@ static const char * const clk_names[clk_max] = { "smc_aper", "swdt", "dbg_trc", "dbg_apb" };

-/**

• • soc_clk_dump() - Print clock frequencies
• • Returns zero on success
• • Implementation for the clk dump command.
• */

-int soc_clk_dump(void) +static int zynq_clk_dump(struct udevice *dev) {

• struct udevice *dev; int i, ret;

• ret = uclass_get_device_by_driver(UCLASS_CLK,

• 			  DM_DRIVER_GET(zynq_clk), &dev);
  

• if (ret)

• return ret;
  

• printf("clk\t\tfrequency\n"); for (i = 0; i < clk_max; i++) { const char *name = clk_names[i];

@@ -511,6 +500,7 @@ int soc_clk_dump(void)

return 0; } +#endif

static struct clk_ops zynq_clk_ops = { .get_rate = zynq_clk_get_rate, @@ -518,6 +508,9 @@ static struct clk_ops zynq_clk_ops = { .set_rate = zynq_clk_set_rate, #endif .enable = dummy_enable, +#if IS_ENABLED(CONFIG_CMD_CLK)

• .dump = zynq_clk_dump,

+#endif };

static int zynq_clk_probe(struct udevice *dev) diff --git a/drivers/clk/clk_zynqmp.c b/drivers/clk/clk_zynqmp.c index be0ee50e0e..c97a0ed963 100644 --- a/drivers/clk/clk_zynqmp.c +++ b/drivers/clk/clk_zynqmp.c @@ -727,16 +727,11 @@ static ulong zynqmp_clk_set_rate(struct clk *clk, ulong rate) } }

-int soc_clk_dump(void) +#if IS_ENABLED(CONFIG_CMD_CLK) +static int zynqmp_clk_dump(struct udevice *dev) {

• struct udevice *dev; int i, ret;

• ret = uclass_get_device_by_driver(UCLASS_CLK,

• DM_DRIVER_GET(zynqmp_clk), &dev);
  

• if (ret)

• return ret;
  

• printf("clk\t\tfrequency\n"); for (i = 0; i < clk_max; i++) { const char *name = clk_names[i];

@@ -764,6 +759,7 @@ int soc_clk_dump(void)

return 0; } +#endif

static int zynqmp_get_freq_by_name(char *name, struct udevice *dev, ulong *freq) { @@ -863,6 +859,9 @@ static struct clk_ops zynqmp_clk_ops = { .set_rate = zynqmp_clk_set_rate, .get_rate = zynqmp_clk_get_rate, .enable = zynqmp_clk_enable, +#if IS_ENABLED(CONFIG_CMD_CLK)

• .dump = zynqmp_clk_dump,

+#endif };

static const struct udevice_id zynqmp_clk_ids[] = { diff --git a/drivers/clk/imx/clk-imx8.c b/drivers/clk/imx/clk-imx8.c index ceeead3434..6cd55f4369 100644 --- a/drivers/clk/imx/clk-imx8.c +++ b/drivers/clk/imx/clk-imx8.c @@ -43,18 +43,12 @@ static int imx8_clk_enable(struct clk *clk) }

#if IS_ENABLED(CONFIG_CMD_CLK) -int soc_clk_dump(void) +static int imx8_clk_dump(struct udevice *dev) {

• struct udevice *dev; struct clk clk; unsigned long rate; int i, ret;

• ret = uclass_get_device_by_driver(UCLASS_CLK,

• 			  DM_DRIVER_GET(imx8_clk), &dev);
  

• if (ret)

• return ret;
  

• printf("Clk\t\tHz\n");

  for (i = 0; i < num_clks; i++) {

@@ -94,6 +88,9 @@ static struct clk_ops imx8_clk_ops = { .get_rate = imx8_clk_get_rate, .enable = imx8_clk_enable, .disable = imx8_clk_disable, +#if IS_ENABLED(CONFIG_CMD_CLK)

• .dump = imx8_clk_dump,

+#endif };

static int imx8_clk_probe(struct udevice *dev) diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mvebu/armada-37xx-periph.c index e75052f383..faf75c8792 100644 --- a/drivers/clk/mvebu/armada-37xx-periph.c +++ b/drivers/clk/mvebu/armada-37xx-periph.c @@ -499,7 +499,7 @@ static int clk_dump(const char *name, int (*func)(struct udevice *))

int armada_37xx_tbg_clk_dump(struct udevice *);

-int soc_clk_dump(void) +static int armada37xx_clk_dump(struct udevice __always_unused *dev) { printf(" xtal at %u000000 Hz\n\n", get_ref_clk());

@@ -605,6 +605,9 @@ static const struct clk_ops armada_37xx_periph_clk_ops = { .set_parent = armada_37xx_periph_clk_set_parent, .enable = armada_37xx_periph_clk_enable, .disable = armada_37xx_periph_clk_disable, +#if IS_ENABLED(CONFIG_CMD_CLK)

• .dump = armada37xx_clk_dump,

+#endif };

static const struct udevice_id armada_37xx_periph_clk_ids[] = { diff --git a/drivers/clk/stm32/clk-stm32mp1.c b/drivers/clk/stm32/clk-stm32mp1.c index 4f4524fcb2..d5b66d48f0 100644 --- a/drivers/clk/stm32/clk-stm32mp1.c +++ b/drivers/clk/stm32/clk-stm32mp1.c @@ -2217,10 +2217,13 @@ static void stm32mp1_osc_init(struct udevice *dev) } }

-static void __maybe_unused stm32mp1_clk_dump(struct stm32mp1_clk_priv *priv) +static int __maybe_unused stm32mp1_clk_dump(struct udevice *dev) { char buf[32]; int i, s, p;

• struct stm32mp1_clk_priv *priv;

• priv = dev_get_priv(dev);

  printf("Clocks:\n"); for (i = 0; i < _PARENT_NB; i++) {

@@ -2242,28 +2245,9 @@ static void __maybe_unused stm32mp1_clk_dump(struct stm32mp1_clk_priv *priv) stm32mp1_clk_parent_sel_name[i], i, p); } } -}

-#ifdef CONFIG_CMD_CLK -int soc_clk_dump(void) -{

• struct udevice *dev;

• struct stm32mp1_clk_priv *priv;

• int ret;

• ret = uclass_get_device_by_driver(UCLASS_CLK,

• 			  DM_DRIVER_GET(stm32mp1_clock),
  

• 			  &dev);
  

• if (ret)

• return ret;
  

• priv = dev_get_priv(dev);

• stm32mp1_clk_dump(priv);

  return 0;

} -#endif

static int stm32mp1_clk_probe(struct udevice *dev) { @@ -2294,7 +2278,7 @@ static int stm32mp1_clk_probe(struct udevice *dev) #if defined(VERBOSE_DEBUG) /* display debug information for probe after relocation */ if (gd->flags & GD_FLG_RELOC)

• stm32mp1_clk_dump(priv);
  

• stm32mp1_clk_dump(dev);
  

#endif

gd->cpu_clk = stm32mp1_clk_get(priv, _CK_MPU); @@ -2325,6 +2309,9 @@ static const struct clk_ops stm32mp1_clk_ops = { .disable = stm32mp1_clk_disable, .get_rate = stm32mp1_clk_get_rate, .set_rate = stm32mp1_clk_set_rate, +#if IS_ENABLED(CONFIG_CMD_CLK) && !IS_ENABLED(CONFIG_SPL_BUILD)

• .dump = stm32mp1_clk_dump,

+#endif };

U_BOOT_DRIVER(stm32mp1_clock) = {

For stm32mp1, tested on stm32mp157c-dk2 board

Tested-by: Patrice Chotard patrice.chotard@foss.st.com

Thanks Patrice