Re: [U-Boot] [PATCH] Cleanup: use constant

Wolfgang,

On Sun, Oct 18, 2009 at 1:41 PM, Wolfgang Denk wd@denx.de wrote:

Dear Niklaus Giger,

In message 1253686334-30500-1-git-send-email-niklaus.giger@netstal.com you wrote:

...

Signed-off-by: Niklaus Giger niklaus.giger@netstal.com

common/miiphyutil.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/common/miiphyutil.c b/common/miiphyutil.c index 66fd9ca..196ef4a 100644 --- a/common/miiphyutil.c +++ b/common/miiphyutil.c @@ -299,7 +299,7 @@ int miiphy_reset (char *devname, unsigned char addr) debug ("PHY status read failed\n"); return (-1); }

• if (miiphy_write (devname, addr, PHY_BMCR, reg | 0x8000) != 0) {
  

• if (miiphy_write (devname, addr, PHY_BMCR, reg | PHY_BMCR_RESET) !=
  

0. {

...

          debug ("PHY reset failed\n");
          return (-1);
  }

Applied, thanks.

Ben, hope this is OK with you.

Yeah, totally OK. A more descriptive title might have been noticed.

Best regards,

Wolfgang Denk

regards, Ben