On Thu, Jul 05, 2012 at 01:57:26PM +0200, Albert ARIBAUD wrote:
Hi Tetsuyuki,
On Fri, 29 Jun 2012 18:36:21 +0900, Tetsuyuki Kobayashi koba@kmckk.co.jp wrote:
save_boot_params_default() in cpu.c accesses uninitialized stack area when it compiled with -O0 (not optimized).
Signed-off-by: Tetsuyuki Kobayashi koba@kmckk.co.jp
Changes for v2:
- include <linux/compiler.h> and use __naked instead of
__attribute__((naked))
Changes for v3:
- move __naked after void
- reformat comments
arch/arm/cpu/armv7/cpu.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
Applied to u-boot-arm/master, thanks.
Oh no... cpu.c: In function 'save_boot_params_default': cpu.c:48:1: warning: -fstack-usage not supported for this target [enabled by default]
Last time we made a const uint32 out of the instruction instead (see 494931a). I don't think that's appropriate here however. Maybe we can declare the function weak in assembly instead, then we won't need the naked part and won't have this warning.