Re: [U-Boot] [PATCH v3 09/10] mx23_olinuxino: Enable USB support

On Mon, Feb 18, 2013 at 8:16 PM, Fabio Estevam festevam@gmail.com wrote:

On Sun, Feb 17, 2013 at 4:45 PM, Otavio Salvador otavio@ossystems.com.br wrote:

...

+#ifdef CONFIG_CMD_USB

•   /* Enable LAN9512 */
  

•   gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1);
  

+#endif

What about doing like we do with other imx devices and write something like:

gpio_direction_output(MXS_GPIO_NR(0, 17), 1);

,where

#define MXS_GPIO_NR(bank, nr) ((bank) * 32 + (nr))

This also aligns with the kernel style.

Awesome; I have added it to v5. Thx!