On Tue, 04 Dec 2018 10:44:19 +0100 Wolfgang Denk wd@denx.de wrote:
Dear Boris,
In message 20181203220726.19370-1-boris.brezillon@bootlin.com you wrote:
It's pretty common to pass arguments that start with a $ and are then expanded by the shell, and I'm this kind of lazy guy that hits tab all the time and expects the shell to suggest something appropriate. So here is a patchset adding support for ${} auto-completion and using the new helper from the mtd command.
You mean, this feature depends on MTD support? this is not goot.
Not at all, MTD is just the first user of this dollar_complete() helper. That's what I meant.
Also, you should make this feature configurable. Not everybody may want to use it or may have the memory available.
It already depends on CONFIG_AUTO_COMPLETE, and each command has to explicitly call the helper to support ${} auto-completion. Not that $ auto-completion only makes sense for some arguments, not all of them. It's the responsibility of the command itself to decide when it should be used.
Technically - should autocompletion not be prevented for escaped '$' characters, i. e. hitting TAB after a '$' sequence should NOT expand?
It's already the case. The argument has to start with $ or ${ to be auto-completed.