Re: [U-Boot] [PATCH] ventana: Add Gateworks Ventana family support

On Mon, Jan 27, 2014 at 3:57 AM, Fabio Estevam festevam@gmail.com wrote:

On Tue, Jan 21, 2014 at 4:41 PM, Tim Harvey tharvey@gateworks.com wrote:

...

+static int setup_pmic_voltages(void) +{

•   int ret;
  

•   unsigned char value, rev_id = 0;
  

•   ret = i2c_set_bus_num(1);
  

•   if (ret)
  

•           return ret;
  

•   if (!i2c_probe(0x8)) {
  

•           if (i2c_read(0x8, 0, 1, &value, 1)) {
  

•                   printf("Read device ID error!\n");
  

•                   return -1;
  

Please use the PMIC API to read/write to the PMIC.

Fabio,

Thanks for the review! I see include/power/pmic.h and will take a look.

Tim

Regards,

Fabio Estevam