Re: [PATCH 02/13] x86: Adjust search range for sysinfo table

Hi Simon,

On Tue, Feb 21, 2023 at 3:49 AM Simon Glass sjg@chromium.org wrote:

Avoid searching starting at 0 since this memory may not be available

Please describe in more detail why memory address 0 is not available?

and the table cannot be there anyway. Start at 0x400 instead.

Signed-off-by: Simon Glass sjg@chromium.org

arch/x86/cpu/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/cpu/cpu.c b/arch/x86/cpu/cpu.c index 6fe6eaf6c84..3394e5b523c 100644 --- a/arch/x86/cpu/cpu.c +++ b/arch/x86/cpu/cpu.c @@ -352,7 +352,7 @@ long locate_coreboot_table(void) long addr;

    /* We look for LBIO in the first 4K of RAM and again at 960KB */

And update the comment here for the memory address 0 too.

•   addr = detect_coreboot_table_at(0x0, 0x1000);
  

•   addr = detect_coreboot_table_at(0x400, 0xc00);
    if (addr < 0)
            addr = detect_coreboot_table_at(0xf0000, 0x1000);
  
  

--

Regards, Bin