On Mon, Jan 20, 2025 at 12:35:26AM +0100, Jonas Karlman wrote:
Hi,
On 2024-04-03 02:00, Jaehoon Chung wrote:
Hi,
On 1/28/24 01:29, Jonas Karlman wrote:
The alignment hole caused by cmdidx in struct mmc_cmd cause strange issues together with the peephole2 optimization on Amlogic SoCs. Following was observed while working on SPL support for Amlogic SoCs.
sd_get_capabilities() normally issue a CMD55 followed by a CMD51. However, on at least Amlogic S905 (Cortex-A53) and S905X3 (Cortex-A55), CMD55 was instead followed by CMD8 (and a few reties) in SPL.
I read your RFC "https://patchwork.ozlabs.org/patch/1841495/
First, I will retry to reproduce your case with other compiler. After that, I will inform again about this patch.
Gentle ping, this patch has been on list for almost a year now.
Have you had any time to reproduce this or can this be merged as-is?
For some reason only Amlogic seem to be affected by this issue.
Poking around in Linux, it looks like this is equivalent to 'struct mmc_command' in include/linux/mmc/core.h and so this makes us equivalent.
Reviewed-by: Tom Rini trini@konsulko.com