Hi Wolfgang Denk,
On 01/29/2013 03:50 PM, Wolfgang Denk wrote:
Dear Nikita Kiryanov,
In message 1359463349-11649-8-git-send-email-nikita@compulab.co.il you wrote:
Add support for loading splash image from NAND
Signed-off-by: Nikita Kiryanov nikita@compulab.co.il Signed-off-by: Igor Grinberg grinberg@compulab.co.il
Changes in V2:
- Added fix to bmp_load_addr to comply with what happens in lcd.c
following patch number 3.
board/cm_t35/cm_t35.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++ include/configs/cm_t35.h | 4 +++ 2 files changed, 69 insertions(+)
Why exactly do you need to add code here?
Is it not sufficient to add, for example, a "nand read" command as part of your "preboot" settings?
The preboot commands are executed after lcd is turned on; ideally, the splashimage should be in the frame buffer before that. There is also the issue of having to fix the bmp load address to the appropriate alignment (to comply with a similar fix in lcd.c from patch 3), and checking for problems such as overwriting U-Boot data with the bmp. I don't think Hush is the right tool for these actions.
Best regards,
Wolfgang Denk