On 3/4/23 16:32, Tom Rini wrote:
On Fri, Mar 03, 2023 at 11:31:22PM +0100, Heinrich Schuchardt wrote:
Kconfig settings that are related to the API for standalone applications should be in the API sub-menu and not on the top level.
CONFIG_STANDALONE_LOAD_ADDR is only relevant if standalone example applications are built.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com
Kconfig | 8 -------- api/Kconfig | 11 ++++++++++- 2 files changed, 10 insertions(+), 9 deletions(-)
Did you put this through CI? It's possible that some envs don't do "loadaddr=CONFIG_STANDALONE_LOAD_ADDR" and not enable API stuff anymore, but I think that's why I did what I did when migrating.
Hello Tom,
we should keep the main Kconfig menu clean of detail settings. I don't thin that there is an issue with the current patch.
STANDALONE_LOAD_ADDR is not used for loadaddr:
$ git grep -n STANDALONE_LOAD_ADDR (based on origin/master)
api/Kconfig:15 config STANDALONE_LOAD_ADDR
config.mk:79 export CONFIG_STANDALONE_LOAD_ADDR
configs/display5_defconfig:33 CONFIG_STANDALONE_LOAD_ADDR=0x10001000
configs/display5_factory_defconfig:30 CONFIG_STANDALONE_LOAD_ADDR=0x10001000
configs/microchip_mpfs_icicle_defconfig:15 CONFIG_STANDALONE_LOAD_ADDR=0x80200000
configs/qemu-riscv32_defconfig:12 CONFIG_STANDALONE_LOAD_ADDR=0x80200000
configs/qemu-riscv32_smode_defconfig:13 CONFIG_STANDALONE_LOAD_ADDR=0x80200000
configs/qemu-riscv32_spl_defconfig:15 CONFIG_STANDALONE_LOAD_ADDR=0x80200000
configs/qemu-riscv64_defconfig:12 CONFIG_STANDALONE_LOAD_ADDR=0x80200000
configs/qemu-riscv64_smode_defconfig:13 CONFIG_STANDALONE_LOAD_ADDR=0x80200000
configs/qemu-riscv64_spl_defconfig:14 CONFIG_STANDALONE_LOAD_ADDR=0x80200000
configs/sifive_unleashed_defconfig:21 CONFIG_STANDALONE_LOAD_ADDR=0x80200000
configs/sifive_unmatched_defconfig:24 CONFIG_STANDALONE_LOAD_ADDR=0x80200000
configs/xtfpga_defconfig:12 CONFIG_STANDALONE_LOAD_ADDR=0x00800000
examples/standalone/Makefile:45 LDFLAGS_STANDALONE += -Ttext $(CONFIG_STANDALONE_LOAD_ADDR)
tools/patman/test_checkpatch.py:208 CONFIG_STANDALONE_LOAD_ADDR
With the patch applied https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/15474 showed no issues.
Best regards
Heinrich