On 14.08.19 11:40, Jagan Teki wrote:
On Mon, Aug 5, 2019 at 6:00 PM Kever Yang kever.yang@rock-chips.com wrote:
On 2019/7/29 下午3:46, Jagan Teki wrote:
Print the reason for reset instead of storing it into env variable in rk3288.
This would help to find the reset reason directly on U-Boot proper logs.
Cc: Wadim Egorov w.egorov@phytec.de Signed-off-by: Jagan Teki jagan@amarulasolutions.com
arch/arm/mach-rockchip/rk3288-board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-rockchip/rk3288-board.c b/arch/arm/mach-rockchip/rk3288-board.c index d3ec141fea..613264d7ee 100644 --- a/arch/arm/mach-rockchip/rk3288-board.c +++ b/arch/arm/mach-rockchip/rk3288-board.c @@ -72,7 +72,7 @@ static void rk3288_detect_reset_reason(void) reason = "unknown reset"; }
env_set("reset_reason", reason);
printf("Reset cause: %s\n", reason);Why this need to set as env before? I didn't touch this code when I migrate
Don't know the proper reason for this, ie why I have CCed Wadim.
Wadim, any comments?
If we put the reset_reason inside an environment variable we can later reuse it from a script, e.g. changing the boot behavior for special cases. Right now I have no usecase for it. So from my side you can just print the reason instead of setting the environment. AFAIR I copied the env-method from another board. btw, board/xilinx/zynqmp/zynqmp.c is doing both.