22 Aug
2014
22 Aug
'14
9:31 p.m.
On 08/22/2014 01:35 AM, Marcel Ziswiler wrote:
This patch adds board support for the Toradex Apalis T30 a computer on module which can be used on different carrier boards.
For the sake of ease of use we do not distinguish between different carrier boards for now as the base module features are deemed sufficient enough for regular booting.
The following functionality is working so far:
- eMMC boot and environment storage
- Gigabit Ethernet (once Thierry's PCIe as well as Marek's i210 patches hit mainline)
- MMC/SD cards (both 8-bit as well as 4-bit slot)
- USB client/host (dual role port as client e.g. for DFU/UMS, other two ports as host)
Looks fine at a quick glance, just one nit below, otherwise, Acked-by: Stephen Warren swarren@nvidia.com
diff --git a/configs/apalis_t30_defconfig b/configs/apalis_t30_defconfig
+/* USB networking support */ +#define CONFIG_USB_HOST_ETHER +#define CONFIG_USB_ETHER_ASIX
+#define CONFIG_USE_ARCH_MEMCPY
That last option isn't set on other Tegra boards; what's it for?