Re: [U-Boot] [PATCH] common/cmd_ext_common: measure throughput

Dear Andreas Bießmann,

In message 1350467910-2014-1-git-send-email-andreas.devel@googlemail.com you wrote:

This patch adds time measurement and throughput calculation for the ext2load and ext4load commands.

...

• unsigned long time_start;

...

• time_start = get_timer(0); if (ext4fs_read((char *)addr, filelen) != filelen) { printf("** Unable to read "%s" from %s %d:%d **\n", filename, argv[1], dev, part); ext4fs_close(); goto fail; }
• time_start = get_timer(time_start);

There, "time_start" is clearly a mis-nomer. How about s/time_start/time/ ?

• print_size(filelen / time_start * 1000, "/s");
  

Does this give reasonable results for small files, say when loading a 20 byte file ?

Best regards,

Wolfgang Denk