Re: [U-Boot] [RFC PATCH v1 2/6] spl: dfu: adding dfu support functions for SPL-DFU

...

diff --git a/include/spl.h b/include/spl.h index af02a6d..8849678 100644 --- a/include/spl.h +++ b/include/spl.h @@ -139,4 +139,14 @@ void spl_board_init(void); */ bool spl_was_boot_source(void);

+/* spl dfu functions */ +/* spl_dfu_mmc - run dfu command with chosen mmc device interface

• • @param usb_index - usb controller number
• • @param mmc_dev - mmc device nubmer
• • @return 0 on success, otherwise error code */ int spl_dfu_mmc(int

+usb_index, int mmc_dev, char *dfu_alt_info); int spl_dfu_cmd(int +usbctrl, char *dfu_alt_info, char *interface, char *devstr); +int spl_dfu_ram_load_image(void);

I think that it would be nice to have doxygen like (/**

/* ...... )

Function description comments for each function.

In this way we would have high quality comments in the code.

Ok, sure.

Regards Ravi