20 Jul
2011
20 Jul
'11
9:11 a.m.
Hi Ajay,
On Tue, Jul 19, 2011 at 12:23 PM, Ajay Bhargav ajay.bhargav@einfochips.com wrote:
----- "Prafulla Wadaskar" prafulla@marvell.com wrote:
You should define all GPIO register in a single struct And point them with base address offsets
I suggest you to add mvgpio.c instead of armada100_gpio.c This will be used in future by other Marvell SoCs.
GPIO registers might vary for other Marvell SoCs? How to deal with that?
I could tell you that for the pxa series branch, the gpio register arrangement not change for years, and still keep it valid for the next generation product.
So mvgpio.c could be used by pxa168(aspen), pxa910(td), pxa610(mmp2), pxa620(mmp3).
Best regards, Lei