On Tue, Dec 01, 2015 at 02:02:50PM +0200, Nikita Kiryanov wrote:
Hi Simon,
On Mon, Nov 30, 2015 at 10:19:06AM -0700, Simon Glass wrote:
Since commit 4188ba3 we get the following warning on rockchip boards:
common/spl/spl_mmc.c:111:10: error: 'mmc' undeclared (first use in this function)
Correct this by move the variable init earlier.
This looks suspicious. If the problem is that the variable is undeclared, the only way to fix it is to declare the variable, which is not what this patch does. I would expect this error to persist with the patch applied. Also, mmc is clearly declared in the function parameter list. It sounds to me like the source of the compile error is somewhere earlier in the code.
It's strange, yes. With gcc-5.x we get an uninitalized warning which I posted a patch for, on rockchip. I'm not sure how on earth it would show up as undeclared, but at least the uninitalized is just over-zealous checking.