Dear Masahiro Yamada,
In message 1370505244-5015-1-git-send-email-yamada.m@jp.panasonic.com you wrote:
This commit adds some prototypes into include/mtd/cfi_flash.h. These functions are defined with a weak attribute in drivers/mtd/cfi_flash.c. This means they can be overrided by board-specific ones if necessary.
When defining such functions under board/ directory or somewhere, cfi_flash.h should be included. This makes sure that board-specfic cfi functions are defined in a correct prototype.
As is, this would just add dead code. Please resubmit this with any patch that would actually make use of this feature. this would also allow us to understand why this approch is needed at all.
+#ifdef CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS
When resubmitting, please keep in mind that new CONFIG_* options like this must be documented in the README.
Best regards,
Wolfgang Denk