Re: [U-Boot] [PATCH v3 1/9] sunxi: add sun7i clocks and timer support.

On Friday, April 18, 2014 at 08:05:42 PM, Ian Campbell wrote: [...]

+static ulong read_timer(void) +{

• struct sunxi_timer_reg *timers =

• (struct sunxi_timer_reg *)SUNXI_TIMER_BASE;
  

• struct sunxi_timer *timer = &timers->timer[TIMER_NUM];
• /* The hardware timer counts down, therefore we invert to

• * produce an incrementing timer. */
  

This comment doesn't follow coding style.

• return ~readl(&timer->val);

+}

[...]

Best regards, Marek Vasut