I suggest keep the debug option - #undef DEBUG.
Sometimes, if we need debug, it is easy to open the debug mode with the switch.
Thanks Dave
-----Original Message----- From: u-boot-users-bounces@lists.sourceforge.net [mailto:u-boot-users-bounces@lists.sourceforge.net] On Behalf Of Phillips Kim Sent: 2008?1?11? 11:30 AM To: Tabi Timur Cc: u-boot-users@lists.sourceforge.net Subject: Re: [U-Boot-Users] [PATCH] Remove #undef DEBUG from MPC83xx boardheader files
On Wed, 9 Jan 2008 10:16:32 -0600 Timur Tabi timur@freescale.com wrote:
Remove the "#undef DEBUG" line from all Freescale 83xx
board header files.
The inclusion of this line makes it impossible to enable
debug code in
other source files, because "#define DEBUG" typically needs
to be defined
before any header files are included.
Signed-off-by: Timur Tabi timur@freescale.com
include/configs/MPC8323ERDB.h | 2 -- include/configs/MPC832XEMDS.h | 2 -- include/configs/MPC8349EMDS.h | 2 -- include/configs/MPC8360EMDS.h | 2 -- include/configs/MPC837XEMDS.h | 2 -- 5 files changed, 0 insertions(+), 10 deletions(-)
hmm..what about the rest of the boards that do this?:
include/configs/AP1000.h:#undef DEBUG include/configs/BAB7xx.h:#undef DEBUG include/configs/EB+MCF-EV123.h:#undef DEBUG include/configs/ELPPC.h:#undef DEBUG include/configs/IPHASE4539.h:#undef DEBUG /* General debug */ include/configs/M5235EVB.h:#undef DEBUG include/configs/M5271EVB.h:#undef DEBUG include/configs/M5329EVB.h:#undef DEBUG include/configs/M54455EVB.h:#undef DEBUG include/configs/MPC8360ERDK.h:#undef DEBUG include/configs/MPC8540EVAL.h:#undef DEBUG include/configs/MVBLUE.h:#undef DEBUG include/configs/QS823.h:#undef DEBUG /* debug output code */ include/configs/QS850.h:#undef DEBUG /* debug output code */ include/configs/QS860T.h:#undef DEBUG /* debug output code */ include/configs/Rattler.h:#undef DEBUG include/configs/ads5121.h:#undef DEBUG include/configs/assabet.h:#undef DEBUG include/configs/ep8248.h:#undef DEBUG include/configs/ep82xxm.h:#undef DEBUG include/configs/gw8260.h:#undef DEBUG /* General debug */ include/configs/mpc7448hpc2.h:#undef DEBUG include/configs/ms7722se.h:#undef DEBUG include/configs/ms7750se.h:#undef DEBUG include/configs/sacsng.h:#undef DEBUG /* General debug */ include/configs/sbc8260.h:#undef DEBUG /* General debug */ include/configs/sbc8349.h:#undef DEBUG
Kim
Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.n et/marketplace _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users