Re: [U-Boot] [PATCH 2/2] cmd_sf: Add handler for +len arg for erase command.

Dear Richard Retanubun,

In message 1297888074-8344-3-git-send-email-RichardRetanubun@RuggedCom.com you wrote:

This patch adds [+]len handler for the erase command that will automatically round up the requested erase length to the flash's sector_size.

---

common/cmd_sf.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++---- 1 files changed, 49 insertions(+), 4 deletions(-)

Please run your patches through checkpatch - this helps avoiding the frustration of seeing rejects due to simple issues like these:

ERROR: Missing Signed-off-by: line(s)

• if (*arg == '+'){

ERROR: space required before the open brace '{'

• if (ret != 1) { goto usage;
• }

WARNING: braces {} are not necessary for single statement blocks

Best regards,

Wolfgang Denk