On Wed, Aug 01, 2012 at 09:19:15AM -0700, Tom Rini wrote:
On Tue, Jul 31, 2012 at 10:13:33PM -0600, Stephen Warren wrote:
The Raspberry Pi model B uses the BCM2835 SoC, has 256MB of RAM, contains an SMSC 9512 USB LAN/Hub chip, and various IO connectors. For more details, see http://www.raspberrypi.org/.
Signed-off-by: Stephen Warren swarren@wwwdotorg.org
[snip]
+int dram_init(void) +{
- gd->ram_size = SZ_256M;
- return 0;
+}
You should use get_ram_size(CONFIG_SYS_SDRAM_BASE, max-possible-dram-size); I say this as I just found a "oh, so that's why mainline reports the right amount of memory and other tree does not" bug yesterday. This should also be in the SoC-generic code area (like say arch/arm/cpu/arm1176/bcm2835/board.c). Sorry I didn't spot this last go-round.
I forgot about the video co-processor change later in the series, so you can disregard this specific comment. But I have some still applicable comments I'm going to add to the 0/13 patch now.