On 06/27/2013 03:58:57 AM, Zhang Haijun-B42677 wrote:
Hi, Scott
Sorry to reply to so late. Pls see my reply below.
Regards & Thanks Haijun.
-----Original Message----- From: Wood Scott-B07421 Sent: Wednesday, May 22, 2013 6:24 AM To: Zhang Haijun-B42677 Cc: Fleming Andy-AFLEMING; u-boot@lists.denx.de; Huang
Changming-R66093;
Zhang Haijun-B42677; Zhang Haijun-B42677; sun york-R58495 Subject: Re: [U-Boot] [PATCH] p1020rdb-pd: platform support
On 04/28/2013 01:17:34 AM, Haijun.Zhang wrote:
From: "Haijun.Zhang" haijun.zhang@freescale.com
Add platform support for p1020rdb-pd
Explain what is different about "-pd" and why this new revision
requires
a separate compile-time target.
[Haijun Wrote:] We use P1020RDB-PD to instead of P1020RDB-PC board later on. They are all supported. Nand, DDR, Nor and Spi Flash are different between them. So I thinks they should be two separate board as P1020UTM and P1020MBG do.
Put this information in the changelog.
If it's due to raw DDR config, say so in the changelog. Is there
any way
we could read a revision register to select the proper DDR config at runtime?
[Haijun Wrote:] Now we read DDR config from SPD fist, if not found read from config file.
Is there any reason why SPD would not be found?
+#if (defined(CONFIG_P1020RDB) || defined(CONFIG_P1020RDB_PD)) #if defined(CONFIG_P1020RDB) #define CONFIG_BOARDNAME "P1020RDB-PC" +#elif defined(CONFIG_P1020RDB_PD) +#define CONFIG_BOARDNAME "P1020RDB-PD" +#endif
CONFIG_P1020RDB is not a good name to mean specifically the -PC
revision.
Change it so that CONFIG_P1020RDB is set for all revisions of
P1020RDB,
and introduce CONFIG_P1020RDB-PC for PC-specific things.
Could you reply to this one?
...and of course I meant CONFIG_P1020RDB_PC rather than CONFIG_P1020RDB-PC. :-)
-Scott