Many functions returned -1 previously. Change them to return appropriate error codes.
Signed-off-by: Joe Hershberger joe.hershberger@ni.com Reported-by: Simon Glass sjg@chromium.org Reviewed-by: Simon Glass sjg@chromium.org
---
Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: -New to v4
Changes in v3: None Changes in v2: None
net/eth.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/eth.c b/net/eth.c index 84919e0..9ad15cd 100644 --- a/net/eth.c +++ b/net/eth.c @@ -227,7 +227,7 @@ int eth_unregister(struct eth_device *dev)
/* No device */ if (!eth_devices) - return -1; + return -ENODEV;
for (cur = eth_devices; cur->next != eth_devices && cur->next != dev; cur = cur->next) @@ -235,7 +235,7 @@ int eth_unregister(struct eth_device *dev)
/* Device not found */ if (cur->next != dev) - return -1; + return -ENODEV;
cur->next = dev->next;
@@ -368,7 +368,7 @@ int eth_init(bd_t *bis)
if (!eth_current) { puts("No ethernet found.\n"); - return -1; + return -ENODEV; }
/* Sync environment with network devices */ @@ -397,7 +397,7 @@ int eth_init(bd_t *bis) eth_try_another(0); } while (old_current != eth_current);
- return -1; + return -ETIMEDOUT; }
void eth_halt(void) @@ -413,7 +413,7 @@ void eth_halt(void) int eth_send(void *packet, int length) { if (!eth_current) - return -1; + return -ENODEV;
return eth_current->send(eth_current, packet, length); } @@ -421,7 +421,7 @@ int eth_send(void *packet, int length) int eth_rx(void) { if (!eth_current) - return -1; + return -ENODEV;
return eth_current->recv(eth_current); }