Wolfgang Denk wrote:
I've looked at get_ram_size(), and I don't think I can use it.
Then fix it, please.
Let me guess, you won't accept my patch until I fix get_ram_size() first and use it, right?
We use phys_addr_t to represent DDR sizes, which is a 64-bit integer on the P1022DS. get_ram_size() takes a 'long' and returns a 'long', so it's not capable of handling the amount of memory that we support on the board.
I can use get_ram_size() to test the lower 2GB of DDR, but I can't use it to verify the amount of RAM in the system.
Do you really have > 4 GB RAM on this board?
Actually, anything more than 2GB would cause the problem, since the maximum value of a long is 2GB. On this particular board, there is only 2GB, but all of our new boards are expected to support more than 4GB of RAM.
If this turns out to be a real problem, we have to fix get_ram_size to handle bigger memory sizes as well. I guess this will needed for more and more systems.
Yes.