Re: [PATCH 1/1] stm32mp1: rng: remove superfluous assignment

On Sun, 16 Feb 2020 at 14:41, Heinrich Schuchardt xypron.glpk@gmx.de wrote:

We should not assign a value that is overwritten before use.

Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de

Acked-by: Sughosh Ganu sughosh.ganu@linaro.org

---

drivers/rng/stm32mp1_rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rng/stm32mp1_rng.c b/drivers/rng/stm32mp1_rng.c index dab3b995eb..e0f0a66c6e 100644 --- a/drivers/rng/stm32mp1_rng.c +++ b/drivers/rng/stm32mp1_rng.c @@ -33,7 +33,7 @@ struct stm32_rng_platdata {

static int stm32_rng_read(struct udevice *dev, void *data, size_t len) {

•   int retval = 0, i;
  

•   int retval, i;
    u32 sr, count, reg;
    size_t increment;
    struct stm32_rng_platdata *pdata = dev_get_platdata(dev);
  

-- 2.25.0