Re: [U-Boot] [PATCH v2 5/9] Drop command-processing code when CONFIG_CMDLINE is disabled

On Sun, Mar 13, 2016 at 07:07:31PM -0600, Simon Glass wrote:

Command parsing and processing code is not needed when the command line is disabled. Remove this code in that case.

Signed-off-by: Simon Glass sjg@chromium.org

[snip]

@@ -102,7 +104,11 @@ int run_command_list(const char *cmd, int len, int flag) * doing a malloc() which is actually required only in a case that * is pretty rare. */ +# ifdef CONFIG_CMDLINE rcode = cli_simple_run_command_list(buff, flag); +# else

• rcode = board_run_command(buff);

+# endif #endif

nit: We don't usually space-indent preprocessor tests and don't anywhere else in this file either.

Otherwise:

Reviewed-by: Tom Rini trini@konsulko.com