Hello Stefan,
On Friday 13 April 2007 09:18, Stefan Roese wrote:
Hi All,
On Friday 13 April 2007 08:54, Grant Likely wrote:
Denis, could you please take a look at this patch and let me know if this patch supersedes your patch:
"Re: [U-Boot-Users] [PATCH] Fix bugs in cmd_ide.c and cmd_scsi.c"
from April, 2nd?
My patch from April, 2nd, fixes this issue already. In my patch I decided to just cast the pointer back to ulong *, since I don't know if it is a good idea to increment a pointer to void *.
Incrementing a void* is safe.
Personally, I prefer the solution in Greg's patch.
I appied Greg's patch and the device# part of Denis's patch to my u-boot-ppc4xx repository. Please give it a try and let me know if the issues are fixed now:
I currently don't have the hardware to test the scsiboot, but I tested "ide_read", "ide_write" and "diskboot". It works, so I assume "scsiboot" is also Ok.
Thank you.
Best regards, Denis