On 10/10/19 11:34 PM, Tom Rini wrote:
On Thu, Oct 10, 2019 at 05:43:00AM +0000, liu hao wrote:
This adds platform code and the device tree for the Phytium FT2004 SoC. The initial support comprises the UART and the GMAC.
Signed-off-by: Steven Hao steven_hao5189@outlook.com
Is this platform in upstream Linux kernel yet? If so, what version are you syncing the dts file from? Also, I see a handful of debug printfs in the code and the defconfig file needs to be generated with 'savedefconfig'. Thanks!
Hello Steven,
Tom means you should run:
make ft2004_defconfig make savedefconfig cp defconfig configs/ft2004_defconfig
After this the settings in ft2004_defconfig will be in the same order as in the generated .config and unnecessary options will be removed.
Unfortunately this is not described in the U-Boot documentation yet.
If you want to keep the debug output, you can replace the printf() statements by debug() which will produce the output if DEBUG is defined. DEBUG should not be defined in the submitted files.
@Tom: The DTS does not exist in linux-next.
Best regards
Heinrich