On 01/24/2013 10:22 AM, Lucas Stach wrote:
Am Freitag, den 25.01.2013, 06:54 +1300 schrieb Simon Glass:
Hi Lucas,
On Fri, Jan 25, 2013 at 5:48 AM, Lucas Stach dev@lynxeye.de wrote:
Init pinmux in one shot, in order to avoid any conflicts.
Signed-off-by: Lucas Stach dev@lynxeye.de
board/nvidia/seaboard/seaboard.c | 133 +++++++++++++++++++++++++++++++++------ include/configs/seaboard.h | 3 + include/configs/ventana.h | 3 + 3 files changed, 121 insertions(+), 18 deletions(-)
This seems like a lot of code and presumably quite a bit of duplication between boards. What sort of conflicts does this avoid, and is it the only way of avoiding them?
I don't see it as duplication, but as explicitly spelling out how the pinmux configuration should be set up on a certain board.
Before this change we would leave some pads uninitialised in their (random) reset configuration.
Just being pedantic here, but I don't think the power-on-reset configuration is random; it's well defined but perhaps just not documented, and not always what is correct/best for any particular board design.