Re: [U-Boot] [PATCH 7/8] rockchip: rk3368: remove uart iomux init in SPL

Hi Kever:

Kever Yang kever.yang@rock-chips.com 于2019年3月29日周五 下午10:55写道：

The iomux should have been set in board_debug_uart_init(), do not set in board_init_f(), remove it.

Signed-off-by: Kever Yang kever.yang@rock-chips.com

arch/arm/mach-rockchip/rk3368-board-spl.c | 13 ------------- 1 file changed, 13 deletions(-)

diff --git a/arch/arm/mach-rockchip/rk3368-board-spl.c b/arch/arm/mach-rockchip/rk3368-board-spl.c index b055ed4aee..9cb5eab8ae 100644 --- a/arch/arm/mach-rockchip/rk3368-board-spl.c +++ b/arch/arm/mach-rockchip/rk3368-board-spl.c @@ -24,19 +24,6 @@ void board_init_f(ulong dummy) hang(); }

•   /* Set up our preloader console */
  

•   ret = uclass_get_device(UCLASS_PINCTRL, 0, &pinctrl);
  
  

the struct udevice* pinctrl definition should also be removed.

•   if (ret) {
  

•           pr_err("%s: pinctrl init failed: %d\n", __func__, ret);
  

•           hang();
  

•   }
  

•   ret = pinctrl_request_noflags(pinctrl, PERIPH_ID_UART0);
  

•   if (ret) {
  

•           pr_err("%s: failed to set up console UART\n", __func__);
  

•           hang();
  

•   }
  

•   preloader_console_init();
  
    ret = uclass_get_device(UCLASS_RAM, 0, &dev);
  

-- 2.20.1

---

U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot