On Mon, May 23, 2022 at 08:19:51AM -0500, Eddie James wrote:
On 5/23/22 01:12, Ilias Apalodimas wrote:
Hi Eddie,
Thanks for the patch.
[...]
+static const struct tpm_tis_chip_data tpm_tis_std_chip_data = {
- .pcr_count = 24,
- .pcr_select_min = 3,
+};
+static const struct udevice_id tpm_tis_i2c_ids[] = {
- {
.compatible = "nuvoton,npct75x",.data = (ulong)&tpm_tis_std_chip_data,- },
- {
.compatible = "tcg,tpm-tis-i2c",.data = (ulong)&tpm_tis_std_chip_data,- },
- { }
+};
+U_BOOT_DRIVER(tpm_tis_i2c) = {
- .name = "tpm_tis_i2c",
- .id = UCLASS_TPM,
- .of_match = tpm_tis_i2c_ids,
- .ops = &tpm_tis_i2c_ops,
- .probe = tpm_tis_i2c_probe,
- .remove = tpm_tis_i2c_remove,
- .priv_auto_alloc_size = sizeof(struct tpm_chip),
Shouldn't this be .priv_auto only? IIRC we got rid of the .priv_auto_alloc_size a while back? If so I can fix this while merging
Yes, I think so. I tested with an older u-boot (openbmc uses a modified v2019.04) with all the TPM core patches, and I think I missed this bit in rebasing.
No worries, I can fix this while merging, there's no need for a v2. I don't see anything obviously wrong with the patchset, unfortunately I don't have an i2c tpm to test. Anyway
Reviewed-by: Ilias Apalodimas ilias.apalodimas@linaro.org
P.S: Was the new TIS API useful?
Thanks /Ilias
Thanks,
Eddie
Regards /Ilias
+};
2.27.0