2013.05.23. 17:49 keltezéssel, Tom Rini írta:
<...>
The pci_indirect.c file is always compiled when CONFIG_PCI is defined although it is not needed at all for Malta PCI support.
The issue can be resolved on a few different ways:
- Extend the '#if !defined(__I386__)' directive in pci_indirect.c with
a new '&& !defined(__MIPS__)' condition. This would be the simplest solution but the drawback of this is that indirect support will not be usable on any MIPS board.
- Introduce a new 'CONFIG_PCI_INDIRECT_BRIDGE' option and only compile
the pci_indirect.c file if this option is present. Probably this is the best solution however the new symbol should be added into the configuration of the affected boards.
- Introduce a new 'CONFIG_PCI_NO_INDIRECT_BRIDGE' option and use an
'#ifndef CONFIG_PCI_NO_INDIRECT_BRIDGE' directive in pci_indirect.c.
I'm unsure about which approach is preferred.
I favor the second option.
A quick check around in the kernel says that microblaze and powerpc have similar type code and keep it under arch/ rather than drivers, but I'm good with option #2.
Ok, I will create a patch for that.
Thanks, Gabor