Hi Stephen
From: Stephen Warren swarren@wwwdotorg.org Sent: lundi 10 février 2020 21:25
On 2/10/20 10:01 AM, Patrick Delaunay wrote:
Add a pytest for testing the env info sub-command:
test_env_info: test command with several option
test_env_info_test: test the result of the sub-commandi with quiet option,
Nit: Remove "i" from the end of "sub-commandi".
yes
diff --git a/test/py/tests/test_env.py b/test/py/tests/test_env.py
+@pytest.mark.boardspec('sandbox')
I assume that's just so things like "environment can't be persisted" can be guaranteed, since other boards will be different to sandbox here?
Yes.
And also the test is based on command "env_loc" (select the env backend used) which is sandbox specific. So this test will failed on real platform.
+@pytest.mark.buildconfigspec('cmd_nvedit_info') +@pytest.mark.buildconfigspec('cmd_echo') +def test_env_info_test(state_test_env):
- """Test 'env info' quiet command result with several options for test.
- """
Nit: It took me a while to realized what the "for test" and "_test" function name suffix meant. Perhaps _retcode might be a better function name suffix?
ok
Acked-by: Stephen Warren swarren@nvidia.com