Re: [U-Boot] [PATCH 5/8] MXC FEC: Resolve speed before configuring gasket

Dear "Timo Ketola",

In message 1334223234-23383-6-git-send-email-timo@exertus.fi you wrote:

Signed-off-by: Timo Ketola timo@exertus.fi

drivers/net/fec_mxc.c | 41 ++++++++++++++++++++++------------------- 1 files changed, 22 insertions(+), 19 deletions(-)

...

• // FIXME: useless call: miiphy_duplex(edev->name, fec->phy_id);

ERROR: do not use C99 // comments

• /* configure gasket for RMII, 50 MHz, no loopback, and no echo */
  

WARNING: line over 80 characters

• writew(MIIGSK_CFGR_IF_MODE_RMII, &fec->eth->miigsk_cfgr);
  

• else

• /* configure gasket for RMII, 5 MHz, no loopback, and no echo */
  

• writew(MIIGSK_CFGR_IF_MODE_RMII | MIIGSK_CFGR_FRCONT, &fec->eth->miigsk_cfgr);
  

WARNING: line over 80 characters

Best regards,

Wolfgang Denk