Hi,
-----Original Message----- From: Bin Meng bmeng.cn@gmail.com Sent: Friday, June 26, 2020 6:50 PM To: Sagar Kadam sagar.kadam@sifive.com Cc: U-Boot Mailing List u-boot@lists.denx.de; Rick Chen rick@andestech.com; Bin Meng bin.meng@windriver.com; Jagan Teki jagan@amarulasolutions.com; Pragnesh Patel pragnesh.patel@sifive.com; Anup Patel anup.patel@wdc.com; Simon Glass sjg@chromium.org; Ye Li ye.li@nxp.com; Peng Fan peng.fan@nxp.com; Sean Anderson seanga2@gmail.com Subject: Re: [PATCH v6 3/4] riscv: cpu: correctly handle the setting of CPU_FEAT_MMU bit
[External Email] Do not click links or attachments unless you recognize the sender and know the content is safe
On Fri, Jun 26, 2020 at 8:41 PM Sagar Shrikant Kadam sagar.kadam@sifive.com wrote:
The conditional check to read "mmu-type" from the device tree is not rightly handled due to which the cpu feature doesn't include CPU_FEAT_MMU even if it's corresponding entry is present in the device tree.
The initialization of cpu features is now taken care in cpu-uclass driver, so no need to zero out cpu_freq in riscv_cpu driver and can be removed.
Signed-off-by: Sagar Shrikant Kadam sagar.kadam@sifive.com Reviewed-by: Pragnesh Patel pragnesh.patel@sifive.com
drivers/cpu/riscv_cpu.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Bin Meng bin.meng@windriver.com
Thanks Bin.
BR, Sagar