Re: [U-Boot] [PATCH] rockchip: video: fix taking the VOP device out of standby

Hi,

On 9 June 2017 at 11:02, Anatolij Gustschin agust@denx.de wrote:

Hi Simon,

On Fri, 9 Jun 2017 18:24:37 +0200 Philipp Tomsich philipp.tomsich@theobroma-systems.com wrote:

...

The VOP uses regular registers, so use setbits_le32/clrbits_le32 instead of rk_setbits/rk_clrbits.

these could be changed when applying, to match with the code:

s/rk_setbits/rk_setreg/ s/rk_clrbits/rk_clrreg/

no need to resubmit I think.

...

Signed-off-by: Philipp Tomsich philipp.tomsich@theobroma-systems.com

Acked-by: Anatolij Gustschin agust@denx.de

Thank you both. I squashed this into the offending patch, in these two commits:

6b5a09aa38 rockchip: video: Take the vop device out of standby f418676e9a rockchip: video: Add remove() methods

Regards, Simon