Liew Tsi Chung wrote:
Ben,
Yes. I agree the function name is not very descriptive. Will mcdmafec_initialize() work (mcdma - multi-channel dma)? I can't name it specific to coldfire, because this driver will also work on MPC8220.
Regards, TsiChung
Sure, that's better.
diff --git a/net/eth.c b/net/eth.c index 5d9e9c1..fd3dc85 100644 --- a/net/eth.c +++ b/net/eth.c @@ -61,6 +61,7 @@ extern int uec_initialize(int); extern int bfin_EMAC_initialize(bd_t *); extern int atstk1000_eth_initialize(bd_t *); extern int mcffec_initialize(bd_t*); +extern int fecdma_initialize(bd_t*);
Can you pick a more descriptive name than fecdma, please. At the very least it should be mcffecdma so we know it's Coldfire.
#ifdef CONFIG_API extern void (*push_packet)(volatile void *, int); @@ -272,6 +273,9 @@
int eth_initialize(bd_t *bis) #if defined(CONFIG_MCFFEC) mcffec_initialize(bis); #endif +#if defined(CONFIG_FSLDMAFEC)
- fecdma_initialize(bis);
+#endif
if (!eth_devices) { puts ("No ethernet found.\n");