On Thu, Jan 24, 2019 at 12:46:32PM +0100, Simon Goldschmidt wrote:
On Tue, Jan 22, 2019 at 11:10 PM Tom Rini trini@konsulko.com wrote:
Make use of "IMAGE_MAX_SIZE" and "IMAGE_TEXT_BASE" rather than CONFIG_SPL_MAX_SIZE and CONFIG_SPL_TEXT_BASE. This lets us re-use the same script for both SPL and TPL. Add logic to scripts/Makefile.spl to pass in the right value when preprocessing the script.
Cc: Stefano Babic sbabic@denx.de Cc: Fabio Estevam fabio.estevam@nxp.com Cc: Jagan Teki jagan@openedev.com Cc: Maxime Ripard maxime.ripard@bootlin.com Cc: Andreas Bießmann andreas@biessmann.org Cc: Philipp Tomsich philipp.tomsich@theobroma-systems.com Cc: Michal Simek monstr@monstr.eu Cc: Daniel Schwierzeck daniel.schwierzeck@gmail.com Cc: York Sun york.sun@nxp.com Cc: Bin Meng bmeng.cn@gmail.com Cc: Heiko Schocher hs@denx.de Cc: Adam Ford aford173@gmail.com Signed-off-by: Tom Rini trini@konsulko.com
Reviewed-by: Simon Goldschmidt simon.k.r.goldschmidt@gmail.com
However, given that it's now "not allowed" to use OF_EMBED, how useful is the current size check? Because if done in the linker, it does not include the DTB.
I think we might need to move the MAX_SIZE check into the Makefile, much like CONFIG_BOARD_SIZE_LIMIT.
I was thinking about that too at one point and yes, there is follow-up work to move that BOARD_SIZE_LIMIT code such that we don't have multiple copies of it and hook more platforms into it.