Hi Rafał,
I love your patch! Perhaps something to improve:
[auto build test WARNING on shawnguo/for-next] [also build test WARNING on soc/for-next linus/master v6.1-rc7 next-20221125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Rafa-Mi-ecki/nvmem-core-refac... base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next patch link: https://lore.kernel.org/r/20221127231035.17547-2-zajec5%40gmail.com patch subject: [PATCH 2/2] nvmem: u-boot-env: reformat MAC in "ethaddr" cell when reading config: x86_64-allyesconfig compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/7ed383c8df3e3a2435255360e03171... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Rafa-Mi-ecki/nvmem-core-refactor-cell_post_process-CB-arguments/20221128-071155 git checkout 7ed383c8df3e3a2435255360e03171ebdc4437b4 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/nvmem/u-boot-env.c: In function 'u_boot_env_cell_post_process':
drivers/nvmem/u-boot-env.c:70:28: warning: unused variable 'priv' [-Wunused-variable]
70 | struct u_boot_env *priv = context; | ^~~~
vim +/priv +70 drivers/nvmem/u-boot-env.c
66 67 static int u_boot_env_cell_post_process(void *context, struct nvmem_cell_entry *cell, 68 const char *id, void *buf, size_t *len) 69 {
70 struct u_boot_env *priv = context;
71 72 if (!strcmp(cell->name, "ethaddr")) { 73 u8 mac[ETH_ALEN]; 74 75 if (mac_pton(buf, mac)) { 76 ether_addr_copy(buf, mac); 77 if (len) 78 *len = ETH_ALEN; 79 } 80 } 81 82 return 0; 83 } 84