Re: [U-Boot] [PATCH] libfdt: introduce function fdt_get_max_phandle

Dear Timur Tabi,

In message 1274308618-2974-1-git-send-email-timur@freescale.com you wrote:

Introduce function fdt_get_max_phandle(), which returns the largest value of all phandles in a device tree. This is useful for allocating a new phandle property, since all phandles must be unique.

Signed-off-by: Timur Tabi timur@freescale.com

include/libfdt.h | 20 ++++++++++++++++++++ lib/libfdt/fdt_ro.c | 17 +++++++++++++++++ 2 files changed, 37 insertions(+), 0 deletions(-)

Please submit as part of a patch / patch series that acrtually uses this feature. As is, it's just dead code that has no users.

+int fdt_get_max_phandle(const void *fdt) +{

• int offset;
• uint32_t temp, phandle = 0;
• FDT_CHECK_HEADER(fdt);
• for (offset = fdt_next_node(fdt, -1, NULL); offset >= 0;

•     offset = fdt_next_node(fdt, offset, NULL)) {
  

• temp = fdt_get_phandle(fdt, offset);
  

• if (temp > phandle)
  

• 	phandle = temp;
  

• }
• return phandle;

+}

As fdt_get_phandle() returns a uint32_t, fdt_get_max_phandle() should return the same type, not int.

Best regards,

Wolfgang Denk