On Tue, Jun 13, 2023 at 07:28:34AM -0600, Rob Herring wrote:
On Mon, Jun 12, 2023 at 3:23 PM Conor Dooley conor@kernel.org wrote:
On Thu, Jun 08, 2023 at 08:30:28PM +0100, Conor Dooley wrote:
On Thu, Jun 08, 2023 at 01:15:37PM -0600, Rob Herring wrote:
On Tue, May 30, 2023 at 03:12:12PM +0100, Conor Dooley wrote:
On Thu, May 18, 2023 at 10:42:34PM +0100, Conor Dooley wrote:
On Thu, May 18, 2023 at 02:30:53PM -0400, Sean Anderson wrote:
> > Why not just have something like > > mycpu { > ... > riscv,isa { > i; > m; > a; > zicsr; > ...
I prefer property names be globally unique. The tools are geared towards that too. That's largely a symptom of having 0 type information in the DT.
For example if you had an extension called 'reg', it would be a problem.
Per the current ISA rules, that'd not be valid. But then again, I do have trust issues & it's not like "reg" is the only property name in DT land.
...you say "prefer" here. Is that a NAK, or a "you keep the pieces"?
Don't do the above node.
Yeah, that's more helpful wording than "prefer" for sure!
If that's a no-go & so are the booleans prefixed with "riscv,whatever-", since people have size concerns, I guess that leaves your string suggestion (there is a helper in Linux at least, haven't checked elsewhere yet).
I guess that means something like:
riscv,isa-extensions: $ref: /schemas/types.yaml#/definitions/string-array minItems: 1 description: Extensions supported by the hart. items: anyOf: - const: i description: foo - const: m description: foo - const: a description: foo - const: f description: foo - const: d description: foo - const: c description: foo - const: zifencei description: foo - etc
Obviously with "foo" replaced by the existing descriptions in this patch.