Re: [U-Boot] [PATCH 02/19] usbdev.c: Fix GCC 4.6 build warnings

Dear Stefan Roese,

In message 1321380112-6210-1-git-send-email-sr@denx.de you wrote:

Fix: usbdev.c: In function 'process_endpoints': usbdev.c:29:12: warning: variable 'temp1' set but not used [-Wunused-but-set-variable] usbdev.c:29:6: warning: variable 'temp' set but not used [-Wunused-but-set-variable]

Signed-off-by: Stefan Roese sr@denx.de

...

@@ -44,8 +43,6 @@ void process_endpoints(unsigned short usb2d0_intrin) /*copy packet */ setup_packet_pt[0] = *(unsigned int *)USB2D0_FIFO_0; setup_packet_pt[1] = *(unsigned int *)USB2D0_FIFO_0;

• temp = *(unsigned int *)USB2D0_FIFO_0;
  

• temp1 = *(unsigned int *)USB2D0_FIFO_0;
  

It seems we agree that these reads from the FIFO registers may actually be important for proper operation. Are you planning to submit an updated, improved patch?

Best regards,

Wolfgang Denk