
3 Oct
2019
3 Oct
'19
10:44 a.m.
On Wed, Oct 2, 2019 at 10:07 PM Bin Meng bmeng.cn@gmail.com wrote:
On Wed, Sep 25, 2019 at 10:13 PM Simon Glass sjg@chromium.org wrote:
At present these two functions are defined in efi_loader.h but only if CONFIG_EFI_LOADER is enabled. But these are functions that are useful to other code, such as that which deals with Intel Handoff Blocks (HOBs).
Move these to the top of the function.
Possibly ascii2unicode() should not be an inline function, since this might impact code size.
Signed-off-by: Simon Glass sjg@chromium.org
In general it seems to be bad form to include parts of headers conditionally.
Changes in v2: None
include/efi_loader.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
applied to u-boot-x86/next, thanks!