Dear Simon Glass,
In message CAPnjgZ18daUnwQtAxtPOU43EGLA7=tN0EFUtbBzKNTDY8DA-sQ@mail.gmail.com you wrote:
Do we really need a new command here?
We already have dtt, which basicly does the same.
It makes no sense to add new commands for each new device, all doing basicly trhe same, just in an incompatible way.
This patch feature does not use i2c as the temperature measurement is inside the SOC. I wonder whether cmd_dtt.c could be extended so that it only does the i2c stuff if CONFIG_SYS_DTT_BUS_NUM is defined. Then you could use dtt_get_temp() to get the termperature as now.
Dtt should actually be completely agnostic of the underlying method to access the devices it operates on. If such generalization is needed now, then yes, it should be added.
Best regards,
Wolfgang Denk