On Monday 22 June 2009 20:12:11 Dirk Behme wrote:
- This preprocessor warning is annoying. Why not enable it in all
configs where needed and then remove this warning here?
I could have done that, but this would not have been so easy. Especially with so many new board ports pending in the u-boot-arch/next branches at that time. And upcoming board ports would probably fallen through the crack as well. So I decided to do it this way.
Is this a long term solution or only waiting for all u-boot-arch/next branches to be merged?
I don't understand this question. The current code with this check is available in mainline. Or not?
For a long term solution this would be annoying. Maybe we can change this after merge window closed?
Why? There could still be new board ports using this NAND code without defining this 64bit printf format option. I don't think this check really hurts.
We could get rid of it of course if we would enable this 64bit printf format on all platforms and removed this option completely. This would cost a bit of image size but would make things easier/simpler. Just my 0.02$...
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================