Dear Alexander Holler,
In message 1301674331-7476-1-git-send-email-holler@ahsoftware.de you wrote:
Those are usefull for compatibility with the kernel. Remove the locally defined pr_debug() in atmel_mci.c.
Signed-off-by: Alexander Holler holler@ahsoftware.de
drivers/mmc/atmel_mci.c | 6 ------ include/common.h | 4 ++++ 2 files changed, 4 insertions(+), 6 deletions(-)
NAK. This is just adding redundant overhead. I don;t want to have yet another incarnation of macros which already exist.
Either replace the code in drivers/mmc/atmel_mci.c by a simple
#define pr_debug(fmt, args...) debug(fmt, ##args)
or convert the code that uses this reference.
And pr_info() is completrely redundant and not used anywhere.
If you really think that pr_debug() is so much better than debug(), then convert ALL code to use that. But I am not a friend of such a change.
Best regards,
Wolfgang Denk